Anton Bulakh
2025-02-25 29c533a265a380feb2877624cbbb8bff4ad66d34
refs
author Anton Bulakh <him@necauq.ua>
Tuesday, February 25, 2025 21:28 +0000
committer GitHub <noreply@github.com>
Tuesday, February 25, 2025 21:28 +0000
commit29c533a265a380feb2877624cbbb8bff4ad66d34
tree ac0f65c42283af5736dcf08e3cb5551a2ba183dc tree | zip | gz
parent 1a0264246913425808718733798f1f110e929cc6 view | diff
fix(aliases): wikilink resolution for aliases (#1681)

With markdownLinkResolution: "shortest", aka "+/- how Obsidian does it"
and given pages A and nested/B which has an alias Z, if you try to link
from A using [[Z]] it wouldn't work and get 404.

This is caused by alias slugs (nested/Z in this case, emitted by
AliasRedirects) not being present in the `allSlugs` list which is used
by the link transformer.

The fix is to compute the alias slugs in the frontmatter transformer
and add them to `allSlugs` there.
Also we store them in file data to avoid recomputing them when emitting
alias redirect pages.

Fixes #904

Note: given how currently the markdown/html transformers are ordered
this doesn't really work.

Given pages A and nested/B which has an alias Z, here's the order which
currently happens:

md-transformers(A) => html-transformers(A) =>
md-transformers(B) => html-transformers(B)

Since the nested/Z slug will get added when md-transformers(B) are run,
but the slugs are used by html-transformers(A) when resolving it's
links - the link [[Z]] in A will still 404

A fix for this is to split the parser into two stages - first apply the
md-transformers to all files, and only then apply html-transformers to
all files.

I did just that in a different commit, which is needed for this one to
work correctly.
2 files modified
62 ■■■■ changed files
quartz/plugins/emitters/aliases.ts 33 ●●●● diff | view | raw | blame | history
quartz/plugins/transformers/frontmatter.ts 29 ●●●● diff | view | raw | blame | history