From e9b60c728595e84b935d8af59a7efcac52ef5ab1 Mon Sep 17 00:00:00 2001
From: Jacky Zhao <j.zhao2k19@gmail.com>
Date: Thu, 10 Apr 2025 23:46:30 +0000
Subject: [PATCH] fix(popover): popover id calculation + scroll consistency
---
quartz/components/scripts/popover.inline.ts | 50 +++++++++++++++++++++++---------------------------
1 files changed, 23 insertions(+), 27 deletions(-)
diff --git a/quartz/components/scripts/popover.inline.ts b/quartz/components/scripts/popover.inline.ts
index 9fd0aaf..04ffd58 100644
--- a/quartz/components/scripts/popover.inline.ts
+++ b/quartz/components/scripts/popover.inline.ts
@@ -9,10 +9,7 @@
this: HTMLAnchorElement,
{ clientX, clientY }: { clientX: number; clientY: number },
) {
- clearActivePopover()
-
const link = this
- const id = randomIdNonSecure()
if (link.dataset.noPopover === "true") {
return
}
@@ -27,23 +24,33 @@
})
}
- const prevPopoverElement = document.getElementById(`popover-${id}`)
- const hasAlreadyBeenFetched = () => !!document.getElementById(`popover-${id}`)
+ function showPopover(popoverElement: HTMLElement) {
+ popoverElement.classList.add("active-popover")
+ setPosition(popoverElement as HTMLElement)
- // dont refetch if there's already a popover
- if (hasAlreadyBeenFetched()) {
- setPosition(prevPopoverElement as HTMLElement)
- prevPopoverElement?.classList.add("active-popover")
- return
+ if (hash !== "") {
+ const targetAnchor = `#popover-internal-${hash.slice(1)}`
+ const heading = popoverInner.querySelector(targetAnchor) as HTMLElement | null
+ if (heading) {
+ // leave ~12px of buffer when scrolling to a heading
+ popoverInner.scroll({ top: heading.offsetTop - 12, behavior: "instant" })
+ }
+ }
}
- const thisUrl = new URL(document.location.href)
- thisUrl.hash = ""
- thisUrl.search = ""
const targetUrl = new URL(link.href)
const hash = decodeURIComponent(targetUrl.hash)
targetUrl.hash = ""
targetUrl.search = ""
+ const popoverId = `popover-${link.dataset.slug ?? randomIdNonSecure()}`
+ const prevPopoverElement = document.getElementById(popoverId)
+ const hasAlreadyBeenFetched = () => !!document.getElementById(popoverId)
+
+ // dont refetch if there's already a popover
+ if (hasAlreadyBeenFetched()) {
+ showPopover(prevPopoverElement as HTMLElement)
+ return
+ }
const response = await fetchCanonical(targetUrl).catch((err) => {
console.error(err)
@@ -59,12 +66,12 @@
const [contentTypeCategory, typeInfo] = contentType.split("/")
const popoverElement = document.createElement("div")
+ popoverElement.id = popoverId
popoverElement.classList.add("popover")
const popoverInner = document.createElement("div")
popoverInner.classList.add("popover-inner")
- popoverElement.appendChild(popoverInner)
-
popoverInner.dataset.contentType = contentType ?? undefined
+ popoverElement.appendChild(popoverInner)
switch (contentTypeCategory) {
case "image":
@@ -100,19 +107,8 @@
elts.forEach((elt) => popoverInner.appendChild(elt))
}
- setPosition(popoverElement)
- popoverElement.id = `popover-${id}`
- popoverElement.classList.add("active-popover")
document.body.appendChild(popoverElement)
-
- if (hash !== "") {
- const targetAnchor = `#popover-internal-${hash.slice(1)}`
- const heading = popoverInner.querySelector(targetAnchor) as HTMLElement | null
- if (heading) {
- // leave ~12px of buffer when scrolling to a heading
- popoverInner.scroll({ top: heading.offsetTop - 12, behavior: "instant" })
- }
- }
+ showPopover(popoverElement)
}
function clearActivePopover() {
--
Gitblit v1.10.0