From c2bea8a4c4aeba440b8a7b043d7ece6343a9d263 Mon Sep 17 00:00:00 2001
From: derfalx <kschneider@falx.tech>
Date: Thu, 08 Jan 2026 01:30:42 +0000
Subject: [PATCH] fix(citation): Language parameter for non en-US settings (#2075)
---
quartz/components/scripts/popover.inline.ts | 28 ++++++++++++++++------------
1 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/quartz/components/scripts/popover.inline.ts b/quartz/components/scripts/popover.inline.ts
index 04ffd58..989af7e 100644
--- a/quartz/components/scripts/popover.inline.ts
+++ b/quartz/components/scripts/popover.inline.ts
@@ -1,15 +1,15 @@
import { computePosition, flip, inline, shift } from "@floating-ui/dom"
import { normalizeRelativeURLs } from "../../util/path"
import { fetchCanonical } from "./util"
-import { randomIdNonSecure } from "../../util/random"
const p = new DOMParser()
+let activeAnchor: HTMLAnchorElement | null = null
async function mouseEnterHandler(
this: HTMLAnchorElement,
{ clientX, clientY }: { clientX: number; clientY: number },
) {
- const link = this
+ const link = (activeAnchor = this)
if (link.dataset.noPopover === "true") {
return
}
@@ -25,6 +25,7 @@
}
function showPopover(popoverElement: HTMLElement) {
+ clearActivePopover()
popoverElement.classList.add("active-popover")
setPosition(popoverElement as HTMLElement)
@@ -42,12 +43,11 @@
const hash = decodeURIComponent(targetUrl.hash)
targetUrl.hash = ""
targetUrl.search = ""
- const popoverId = `popover-${link.dataset.slug ?? randomIdNonSecure()}`
+ const popoverId = `popover-${link.pathname}`
const prevPopoverElement = document.getElementById(popoverId)
- const hasAlreadyBeenFetched = () => !!document.getElementById(popoverId)
// dont refetch if there's already a popover
- if (hasAlreadyBeenFetched()) {
+ if (!!document.getElementById(popoverId)) {
showPopover(prevPopoverElement as HTMLElement)
return
}
@@ -56,11 +56,6 @@
console.error(err)
})
- // bailout if another popover exists
- if (hasAlreadyBeenFetched()) {
- return
- }
-
if (!response) return
const [contentType] = response.headers.get("Content-Type")!.split(";")
const [contentTypeCategory, typeInfo] = contentType.split("/")
@@ -107,20 +102,29 @@
elts.forEach((elt) => popoverInner.appendChild(elt))
}
+ if (!!document.getElementById(popoverId)) {
+ return
+ }
+
document.body.appendChild(popoverElement)
+ if (activeAnchor !== this) {
+ return
+ }
+
showPopover(popoverElement)
}
function clearActivePopover() {
+ activeAnchor = null
const allPopoverElements = document.querySelectorAll(".popover")
allPopoverElements.forEach((popoverElement) => popoverElement.classList.remove("active-popover"))
}
document.addEventListener("nav", () => {
- const links = [...document.getElementsByClassName("internal")] as HTMLAnchorElement[]
+ const links = [...document.querySelectorAll("a.internal")] as HTMLAnchorElement[]
for (const link of links) {
- link.addEventListener("mouseleave", clearActivePopover)
link.addEventListener("mouseenter", mouseEnterHandler)
+ link.addEventListener("mouseleave", clearActivePopover)
window.addCleanup(() => {
link.removeEventListener("mouseenter", mouseEnterHandler)
link.removeEventListener("mouseleave", clearActivePopover)
--
Gitblit v1.10.0