From c00089bd5728188ce554303b5b18754467c97c85 Mon Sep 17 00:00:00 2001
From: Jacky Zhao <j.zhao2k19@gmail.com>
Date: Fri, 02 Feb 2024 05:19:51 +0000
Subject: [PATCH] chore: add window.addCleanup() for cleaning up handlers
---
quartz/components/scripts/popover.inline.ts | 111 ++++++++++++++++++++++++++++++++++++++-----------------
1 files changed, 76 insertions(+), 35 deletions(-)
diff --git a/quartz/components/scripts/popover.inline.ts b/quartz/components/scripts/popover.inline.ts
index 24c6aec..0251834 100644
--- a/quartz/components/scripts/popover.inline.ts
+++ b/quartz/components/scripts/popover.inline.ts
@@ -1,41 +1,82 @@
-import { computePosition, inline, shift, autoPlacement } from "@floating-ui/dom"
+import { computePosition, flip, inline, shift } from "@floating-ui/dom"
+import { normalizeRelativeURLs } from "../../util/path"
+
+const p = new DOMParser()
+async function mouseEnterHandler(
+ this: HTMLLinkElement,
+ { clientX, clientY }: { clientX: number; clientY: number },
+) {
+ const link = this
+ if (link.dataset.noPopover === "true") {
+ return
+ }
+
+ async function setPosition(popoverElement: HTMLElement) {
+ const { x, y } = await computePosition(link, popoverElement, {
+ middleware: [inline({ x: clientX, y: clientY }), shift(), flip()],
+ })
+ Object.assign(popoverElement.style, {
+ left: `${x}px`,
+ top: `${y}px`,
+ })
+ }
+
+ const hasAlreadyBeenFetched = () =>
+ [...link.children].some((child) => child.classList.contains("popover"))
+
+ // dont refetch if there's already a popover
+ if (hasAlreadyBeenFetched()) {
+ return setPosition(link.lastChild as HTMLElement)
+ }
+
+ const thisUrl = new URL(document.location.href)
+ thisUrl.hash = ""
+ thisUrl.search = ""
+ const targetUrl = new URL(link.href)
+ const hash = targetUrl.hash
+ targetUrl.hash = ""
+ targetUrl.search = ""
+
+ const contents = await fetch(`${targetUrl}`)
+ .then((res) => res.text())
+ .catch((err) => {
+ console.error(err)
+ })
+
+ // bailout if another popover exists
+ if (hasAlreadyBeenFetched()) {
+ return
+ }
+
+ if (!contents) return
+ const html = p.parseFromString(contents, "text/html")
+ normalizeRelativeURLs(html, targetUrl)
+ const elts = [...html.getElementsByClassName("popover-hint")]
+ if (elts.length === 0) return
+
+ const popoverElement = document.createElement("div")
+ popoverElement.classList.add("popover")
+ const popoverInner = document.createElement("div")
+ popoverInner.classList.add("popover-inner")
+ popoverElement.appendChild(popoverInner)
+ elts.forEach((elt) => popoverInner.appendChild(elt))
+
+ setPosition(popoverElement)
+ link.appendChild(popoverElement)
+
+ if (hash !== "") {
+ const heading = popoverInner.querySelector(hash) as HTMLElement | null
+ if (heading) {
+ // leave ~12px of buffer when scrolling to a heading
+ popoverInner.scroll({ top: heading.offsetTop - 12, behavior: "instant" })
+ }
+ }
+}
document.addEventListener("nav", () => {
const links = [...document.getElementsByClassName("internal")] as HTMLLinkElement[]
- const p = new DOMParser()
for (const link of links) {
- link.addEventListener("mouseenter", async ({ clientX, clientY }) => {
- if (link.dataset.fetchedPopover === "true") return
- const url = link.href
- const contents = await fetch(`${url}`)
- .then((res) => res.text())
- .catch((err) => {
- console.error(err)
- })
- if (!contents) return
- const html = p.parseFromString(contents, "text/html")
- const elts = [...html.getElementsByClassName("popover-hint")]
- if (elts.length === 0) return
-
-
- const popoverElement = document.createElement("div")
- popoverElement.classList.add("popover")
- elts.forEach(elt => popoverElement.appendChild(elt))
-
- const { x, y } = await computePosition(link, popoverElement, {
- middleware: [inline({
- x: clientX,
- y: clientY
- }), shift(), autoPlacement()]
- })
-
- Object.assign(popoverElement.style, {
- left: `${x}px`,
- top: `${y}px`,
- })
-
- link.appendChild(popoverElement)
- link.dataset.fetchedPopover = "true"
- })
+ link.addEventListener("mouseenter", mouseEnterHandler)
+ window.addCleanup(() => link.removeEventListener("mouseenter", mouseEnterHandler))
}
})
--
Gitblit v1.10.0