From bfa938cc62113391e4022c5a22390d3096770ded Mon Sep 17 00:00:00 2001
From: Jacky Zhao <j.zhao2k19@gmail.com>
Date: Wed, 12 Mar 2025 17:42:07 +0000
Subject: [PATCH] fix(explorer): allow setting displayName (closes #1824)
---
quartz/util/fileTrie.test.ts | 68 ++++++++++++++++++++++++++--------
1 files changed, 52 insertions(+), 16 deletions(-)
diff --git a/quartz/util/fileTrie.test.ts b/quartz/util/fileTrie.test.ts
index 3de3d93..456cf23 100644
--- a/quartz/util/fileTrie.test.ts
+++ b/quartz/util/fileTrie.test.ts
@@ -11,16 +11,15 @@
let trie: FileTrieNode<TestData>
beforeEach(() => {
- trie = new FileTrieNode<TestData>("")
+ trie = new FileTrieNode<TestData>([])
})
describe("constructor", () => {
test("should create an empty trie", () => {
assert.deepStrictEqual(trie.children, [])
- assert.strictEqual(trie.slugSegment, "")
+ assert.strictEqual(trie.slug, "")
assert.strictEqual(trie.displayName, "")
assert.strictEqual(trie.data, null)
- assert.strictEqual(trie.depth, 0)
})
test("should set displayName from data title", () => {
@@ -32,6 +31,17 @@
trie.add(data)
assert.strictEqual(trie.children[0].displayName, "Test Title")
})
+
+ test("should be able to set displayName", () => {
+ const data = {
+ title: "Test Title",
+ slug: "test",
+ }
+
+ trie.add(data)
+ trie.children[0].displayName = "Modified"
+ assert.strictEqual(trie.children[0].displayName, "Modified")
+ })
})
describe("add", () => {
@@ -43,7 +53,7 @@
trie.add(data)
assert.strictEqual(trie.children.length, 1)
- assert.strictEqual(trie.children[0].slugSegment, "test")
+ assert.strictEqual(trie.children[0].slug, "test")
assert.strictEqual(trie.children[0].data, data)
})
@@ -72,20 +82,20 @@
trie.add(data1)
trie.add(data2)
assert.strictEqual(trie.children.length, 2)
- assert.strictEqual(trie.children[0].slugSegment, "folder")
+ assert.strictEqual(trie.children[0].slug, "folder/index")
assert.strictEqual(trie.children[0].children.length, 1)
- assert.strictEqual(trie.children[0].children[0].slugSegment, "test")
+ assert.strictEqual(trie.children[0].children[0].slug, "folder/test")
assert.strictEqual(trie.children[0].children[0].data, data1)
- assert.strictEqual(trie.children[1].slugSegment, "a")
+ assert.strictEqual(trie.children[1].slug, "a/index")
assert.strictEqual(trie.children[1].children.length, 1)
assert.strictEqual(trie.children[1].data, null)
- assert.strictEqual(trie.children[1].children[0].slugSegment, "b")
+ assert.strictEqual(trie.children[1].children[0].slug, "a/b/index")
assert.strictEqual(trie.children[1].children[0].children.length, 1)
assert.strictEqual(trie.children[1].children[0].data, null)
- assert.strictEqual(trie.children[1].children[0].children[0].slugSegment, "c")
+ assert.strictEqual(trie.children[1].children[0].children[0].slug, "a/b/c/index")
assert.strictEqual(trie.children[1].children[0].children[0].data, data2)
assert.strictEqual(trie.children[1].children[0].children[0].children.length, 0)
})
@@ -99,9 +109,9 @@
trie.add(data1)
trie.add(data2)
- trie.filter((node) => node.slugSegment !== "test1")
+ trie.filter((node) => node.slug !== "test1")
assert.strictEqual(trie.children.length, 1)
- assert.strictEqual(trie.children[0].slugSegment, "test2")
+ assert.strictEqual(trie.children[0].slug, "test2")
})
})
@@ -115,13 +125,34 @@
trie.map((node) => {
if (node.data) {
- node.displayName = "Modified"
+ node.data.title = "Modified"
}
})
assert.strictEqual(trie.children[0].displayName, "Modified")
assert.strictEqual(trie.children[1].displayName, "Modified")
})
+
+ test("map over folders should work", () => {
+ const data1 = { title: "Test1", slug: "test1" }
+ const data2 = { title: "Test2", slug: "a/b/test2" }
+
+ trie.add(data1)
+ trie.add(data2)
+
+ trie.map((node) => {
+ if (node.isFolder) {
+ node.displayName = `Folder: ${node.displayName}`
+ } else {
+ node.displayName = `File: ${node.displayName}`
+ }
+ })
+
+ assert.strictEqual(trie.children[0].displayName, "File: Test1")
+ assert.strictEqual(trie.children[1].displayName, "Folder: a")
+ assert.strictEqual(trie.children[1].children[0].displayName, "Folder: b")
+ assert.strictEqual(trie.children[1].children[0].children[0].displayName, "File: Test2")
+ })
})
describe("entries", () => {
@@ -136,7 +167,7 @@
assert.deepStrictEqual(
entries.map(([path, node]) => [path, node.data]),
[
- ["", trie.data],
+ ["index", trie.data],
["test1", data1],
["a/index", null],
["a/b/index", null],
@@ -166,7 +197,12 @@
trie.add(data3)
const paths = trie.getFolderPaths()
- assert.deepStrictEqual(paths, ["folder/index", "folder/subfolder/index", "abc/index"])
+ assert.deepStrictEqual(paths, [
+ "index",
+ "folder/index",
+ "folder/subfolder/index",
+ "abc/index",
+ ])
})
})
@@ -180,9 +216,9 @@
trie.add(data1)
trie.add(data2)
- trie.sort((a, b) => a.slugSegment.localeCompare(b.slugSegment))
+ trie.sort((a, b) => a.slug.localeCompare(b.slug))
assert.deepStrictEqual(
- trie.children.map((n) => n.slugSegment),
+ trie.children.map((n) => n.slug),
["a", "b", "c"],
)
})
--
Gitblit v1.10.0