From 9cefcd0dd1a503c727c8bbb2deb1b631329b3a42 Mon Sep 17 00:00:00 2001
From: Jacky Zhao <j.zhao2k19@gmail.com>
Date: Fri, 20 Sep 2024 22:48:14 +0000
Subject: [PATCH] Revert "perf: eagerly compute explorer nodes to avoid re-render in memoized value"
---
quartz/components/scripts/util.ts | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/quartz/components/scripts/util.ts b/quartz/components/scripts/util.ts
index a97faa6..d0a16c6 100644
--- a/quartz/components/scripts/util.ts
+++ b/quartz/components/scripts/util.ts
@@ -3,6 +3,7 @@
function click(this: HTMLElement, e: HTMLElementEventMap["click"]) {
if (e.target !== this) return
e.preventDefault()
+ e.stopPropagation()
cb()
}
@@ -12,10 +13,10 @@
cb()
}
- outsideContainer?.removeEventListener("click", click)
outsideContainer?.addEventListener("click", click)
- document.removeEventListener("keydown", esc)
- document.addEventListener('keydown', esc)
+ window.addCleanup(() => outsideContainer?.removeEventListener("click", click))
+ document.addEventListener("keydown", esc)
+ window.addCleanup(() => document.removeEventListener("keydown", esc))
}
export function removeAllChildren(node: HTMLElement) {
--
Gitblit v1.10.0