From 83bdcd58e6a88f234d399c0022742b1ee355d434 Mon Sep 17 00:00:00 2001
From: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Fri, 05 Apr 2024 20:02:00 +0000
Subject: [PATCH] chore(deps): bump d3 from 7.8.5 to 7.9.0 (#1047)
---
docs/advanced/creating components.md | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/advanced/creating components.md b/docs/advanced/creating components.md
index 1496b15..27369ab 100644
--- a/docs/advanced/creating components.md
+++ b/docs/advanced/creating components.md
@@ -156,12 +156,13 @@
// do page specific logic here
// e.g. attach event listeners
const toggleSwitch = document.querySelector("#switch") as HTMLInputElement
- toggleSwitch.removeEventListener("change", switchTheme)
toggleSwitch.addEventListener("change", switchTheme)
+ window.addCleanup(() => toggleSwitch.removeEventListener("change", switchTheme))
})
```
-It is best practice to also unmount any existing event handlers to prevent memory leaks.
+It is best practice to track any event handlers via `window.addCleanup` to prevent memory leaks.
+This will get called on page navigation.
#### Importing Code
--
Gitblit v1.10.0