From 52ca312f41ee6da5202cd9632d8501340ada3a67 Mon Sep 17 00:00:00 2001
From: Jacky Zhao <j.zhao2k19@gmail.com>
Date: Sun, 27 Aug 2023 19:27:55 +0000
Subject: [PATCH] fix: slugify tag on page before adding (closes #411)
---
quartz/bootstrap-cli.mjs | 283 ++++++++++++++++++++++++++++++++++++++++---------------
1 files changed, 204 insertions(+), 79 deletions(-)
diff --git a/quartz/bootstrap-cli.mjs b/quartz/bootstrap-cli.mjs
index a39e291..1deb18f 100755
--- a/quartz/bootstrap-cli.mjs
+++ b/quartz/bootstrap-cli.mjs
@@ -16,10 +16,11 @@
import serveHandler from "serve-handler"
import { WebSocketServer } from "ws"
import { randomUUID } from "crypto"
+import { Mutex } from "async-mutex"
const ORIGIN_NAME = "origin"
const UPSTREAM_NAME = "upstream"
-const QUARTZ_SOURCE_BRANCH = "v4-alpha"
+const QUARTZ_SOURCE_BRANCH = "v4"
const cwd = process.cwd()
const cacheDir = path.join(cwd, ".quartz-cache")
const cacheFile = "./.quartz-cache/transpiled-build.mjs"
@@ -42,6 +43,27 @@
},
}
+const CreateArgv = {
+ ...CommonArgv,
+ source: {
+ string: true,
+ alias: ["s"],
+ describe: "source directory to copy/create symlink from",
+ },
+ strategy: {
+ string: true,
+ alias: ["X"],
+ choices: ["new", "copy", "symlink"],
+ describe: "strategy for content folder setup",
+ },
+ links: {
+ string: true,
+ alias: ["l"],
+ choices: ["absolute", "shortest", "relative"],
+ describe: "strategy to resolve links",
+ },
+}
+
const SyncArgv = {
...CommonArgv,
commit: {
@@ -76,6 +98,7 @@
},
baseDir: {
string: true,
+ default: "",
describe: "base path to serve your local server on",
},
port: {
@@ -135,32 +158,83 @@
function gitPull(origin, branch) {
const flags = ["--no-rebase", "--autostash", "-s", "recursive", "-X", "ours", "--no-edit"]
- spawnSync("git", ["pull", ...flags, origin, branch], { stdio: "inherit" })
+ const out = spawnSync("git", ["pull", ...flags, origin, branch], { stdio: "inherit" })
+ if (out.stderr) {
+ throw new Error(`Error while pulling updates: ${out.stderr}`)
+ }
}
yargs(hideBin(process.argv))
.scriptName("quartz")
.version(version)
.usage("$0 <cmd> [args]")
- .command("create", "Initialize Quartz", CommonArgv, async (argv) => {
+ .command("create", "Initialize Quartz", CreateArgv, async (argv) => {
console.log()
intro(chalk.bgGreen.black(` Quartz v${version} `))
const contentFolder = path.join(cwd, argv.directory)
- const setupStrategy = exitIfCancel(
- await select({
- message: `Choose how to initialize the content in \`${contentFolder}\``,
- options: [
- { value: "new", label: "Empty Quartz" },
- { value: "copy", label: "Copy an existing folder", hint: "overwrites `content`" },
- {
- value: "symlink",
- label: "Symlink an existing folder",
- hint: "don't select this unless you know what you are doing!",
- },
- { value: "keep", label: "Keep the existing files" },
- ],
- }),
- )
+ let setupStrategy = argv.strategy?.toLowerCase()
+ let linkResolutionStrategy = argv.links?.toLowerCase()
+ const sourceDirectory = argv.source
+
+ // If all cmd arguments were provided, check if theyre valid
+ if (setupStrategy && linkResolutionStrategy) {
+ // If setup isn't, "new", source argument is required
+ if (setupStrategy !== "new") {
+ // Error handling
+ if (!sourceDirectory) {
+ outro(
+ chalk.red(
+ `Setup strategies (arg '${chalk.yellow(
+ `-${CreateArgv.strategy.alias[0]}`,
+ )}') other than '${chalk.yellow(
+ "new",
+ )}' require content folder argument ('${chalk.yellow(
+ `-${CreateArgv.source.alias[0]}`,
+ )}') to be set`,
+ ),
+ )
+ process.exit(1)
+ } else {
+ if (!fs.existsSync(sourceDirectory)) {
+ outro(
+ chalk.red(
+ `Input directory to copy/symlink 'content' from not found ('${chalk.yellow(
+ sourceDirectory,
+ )}', invalid argument "${chalk.yellow(`-${CreateArgv.source.alias[0]}`)})`,
+ ),
+ )
+ process.exit(1)
+ } else if (!fs.lstatSync(sourceDirectory).isDirectory()) {
+ outro(
+ chalk.red(
+ `Source directory to copy/symlink 'content' from is not a directory (found file at '${chalk.yellow(
+ sourceDirectory,
+ )}', invalid argument ${chalk.yellow(`-${CreateArgv.source.alias[0]}`)}")`,
+ ),
+ )
+ process.exit(1)
+ }
+ }
+ }
+ }
+
+ // Use cli process if cmd args werent provided
+ if (!setupStrategy) {
+ setupStrategy = exitIfCancel(
+ await select({
+ message: `Choose how to initialize the content in \`${contentFolder}\``,
+ options: [
+ { value: "new", label: "Empty Quartz" },
+ { value: "copy", label: "Copy an existing folder", hint: "overwrites `content`" },
+ {
+ value: "symlink",
+ label: "Symlink an existing folder",
+ hint: "don't select this unless you know what you are doing!",
+ },
+ ],
+ }),
+ )
+ }
async function rmContentFolder() {
const contentStat = await fs.promises.lstat(contentFolder)
@@ -171,34 +245,41 @@
}
}
+ await fs.promises.unlink(path.join(contentFolder, ".gitkeep"))
if (setupStrategy === "copy" || setupStrategy === "symlink") {
- const originalFolder = escapePath(
- exitIfCancel(
- await text({
- message: "Enter the full path to existing content folder",
- placeholder:
- "On most terminal emulators, you can drag and drop a folder into the window and it will paste the full path",
- validate(fp) {
- const fullPath = escapePath(fp)
- if (!fs.existsSync(fullPath)) {
- return "The given path doesn't exist"
- } else if (!fs.lstatSync(fullPath).isDirectory()) {
- return "The given path is not a folder"
- }
- },
- }),
- ),
- )
+ let originalFolder = sourceDirectory
+
+ // If input directory was not passed, use cli
+ if (!sourceDirectory) {
+ originalFolder = escapePath(
+ exitIfCancel(
+ await text({
+ message: "Enter the full path to existing content folder",
+ placeholder:
+ "On most terminal emulators, you can drag and drop a folder into the window and it will paste the full path",
+ validate(fp) {
+ const fullPath = escapePath(fp)
+ if (!fs.existsSync(fullPath)) {
+ return "The given path doesn't exist"
+ } else if (!fs.lstatSync(fullPath).isDirectory()) {
+ return "The given path is not a folder"
+ }
+ },
+ }),
+ ),
+ )
+ }
await rmContentFolder()
if (setupStrategy === "copy") {
- await fs.promises.cp(originalFolder, contentFolder, { recursive: true, preserveTimestamps: true })
+ await fs.promises.cp(originalFolder, contentFolder, {
+ recursive: true,
+ preserveTimestamps: true,
+ })
} else if (setupStrategy === "symlink") {
await fs.promises.symlink(originalFolder, contentFolder, "dir")
}
} else if (setupStrategy === "new") {
- await rmContentFolder()
- await fs.promises.mkdir(contentFolder)
await fs.promises.writeFile(
path.join(contentFolder, "index.md"),
`---
@@ -211,29 +292,32 @@
)
}
- // get a prefered link resolution strategy
- const linkResolutionStrategy = exitIfCancel(
- await select({
- message: `Choose how Quartz should resolve links in your content. You can change this later in \`quartz.config.ts\`.`,
- options: [
- {
- value: "absolute",
- label: "Treat links as absolute path",
- hint: "for content made for Quartz 3 and Hugo",
- },
- {
- value: "shortest",
- label: "Treat links as shortest path",
- hint: "for most Obsidian vaults",
- },
- {
- value: "relative",
- label: "Treat links as relative paths",
- hint: "for just normal Markdown files",
- },
- ],
- }),
- )
+ // Use cli process if cmd args werent provided
+ if (!linkResolutionStrategy) {
+ // get a preferred link resolution strategy
+ linkResolutionStrategy = exitIfCancel(
+ await select({
+ message: `Choose how Quartz should resolve links in your content. You can change this later in \`quartz.config.ts\`.`,
+ options: [
+ {
+ value: "absolute",
+ label: "Treat links as absolute path",
+ hint: "for content made for Quartz 3 and Hugo",
+ },
+ {
+ value: "shortest",
+ label: "Treat links as shortest path",
+ hint: "for most Obsidian vaults",
+ },
+ {
+ value: "relative",
+ label: "Treat links as relative paths",
+ hint: "for just normal Markdown files",
+ },
+ ],
+ }),
+ )
+ }
// now, do config changes
const configFilePath = path.join(cwd, "quartz.config.ts")
@@ -247,20 +331,20 @@
outro(`You're all set! Not sure what to do next? Try:
• Customizing Quartz a bit more by editing \`quartz.config.ts\`
• Running \`npx quartz build --serve\` to preview your Quartz locally
- • Hosting your Quartz online (see: https://quartz.jzhao.xyz/setup/hosting)
+ • Hosting your Quartz online (see: https://quartz.jzhao.xyz/hosting)
`)
})
.command("update", "Get the latest Quartz updates", CommonArgv, async (argv) => {
const contentFolder = path.join(cwd, argv.directory)
console.log(chalk.bgGreen.black(`\n Quartz v${version} \n`))
console.log("Backing up your content")
+ execSync(
+ `git remote show upstream || git remote add upstream https://github.com/jackyzha0/quartz.git`,
+ )
await stashContentFolder(contentFolder)
console.log(
"Pulling updates... you may need to resolve some `git` conflicts if you've made changes to components or plugins.",
)
- execSync(
- `git remote show upstream || git remote add upstream https://github.com/jackyzha0/quartz.git`,
- )
gitPull(UPSTREAM_NAME, QUARTZ_SOURCE_BRANCH)
await popContentFolder(contentFolder)
console.log("Ensuring dependencies are up to date")
@@ -384,13 +468,29 @@
],
})
- const timeoutIds = new Set()
+ const buildMutex = new Mutex()
+ let lastBuildMs = 0
+ let cleanupBuild = null
const build = async (clientRefresh) => {
+ const buildStart = new Date().getTime()
+ lastBuildMs = buildStart
+ const release = await buildMutex.acquire()
+ if (lastBuildMs > buildStart) {
+ release()
+ return
+ }
+
+ if (cleanupBuild) {
+ await cleanupBuild()
+ console.log(chalk.yellow("Detected a source code change, doing a hard rebuild..."))
+ }
+
const result = await ctx.rebuild().catch((err) => {
console.error(`${chalk.red("Couldn't parse Quartz configuration:")} ${fp}`)
console.log(`Reason: ${chalk.grey(err)}`)
process.exit(1)
})
+ release()
if (argv.bundleInfo) {
const outputFileName = "quartz/.quartz-cache/transpiled-build.mjs"
@@ -406,39 +506,59 @@
// bypass module cache
// https://github.com/nodejs/modules/issues/307
const { default: buildQuartz } = await import(cacheFile + `?update=${randomUUID()}`)
- await buildQuartz(argv, clientRefresh)
+ cleanupBuild = await buildQuartz(argv, buildMutex, clientRefresh)
clientRefresh()
}
- const rebuild = (clientRefresh) => {
- timeoutIds.forEach((id) => clearTimeout(id))
- timeoutIds.add(setTimeout(() => build(clientRefresh), 250))
- }
-
if (argv.serve) {
- const wss = new WebSocketServer({ port: 3001 })
const connections = []
- wss.on("connection", (ws) => connections.push(ws))
const clientRefresh = () => connections.forEach((conn) => conn.send("rebuild"))
+ if (argv.baseDir !== "" && !argv.baseDir.startsWith("/")) {
+ argv.baseDir = "/" + argv.baseDir
+ }
+
await build(clientRefresh)
const server = http.createServer(async (req, res) => {
+ if (argv.baseDir && !req.url?.startsWith(argv.baseDir)) {
+ console.log(
+ chalk.red(
+ `[404] ${req.url} (warning: link outside of site, this is likely a Quartz bug)`,
+ ),
+ )
+ res.writeHead(404)
+ res.end()
+ return
+ }
+
+ // strip baseDir prefix
+ req.url = req.url?.slice(argv.baseDir.length)
+
const serve = async () => {
+ const release = await buildMutex.acquire()
await serveHandler(req, res, {
public: argv.output,
directoryListing: false,
+ headers: [
+ {
+ source: "**/*.html",
+ headers: [{ key: "Content-Disposition", value: "inline" }],
+ },
+ ],
})
const status = res.statusCode
const statusString =
status >= 200 && status < 300 ? chalk.green(`[${status}]`) : chalk.red(`[${status}]`)
- console.log(statusString + chalk.grey(` ${req.url}`))
+ console.log(statusString + chalk.grey(` ${argv.baseDir}${req.url}`))
+ release()
}
const redirect = (newFp) => {
+ newFp = argv.baseDir + newFp
res.writeHead(302, {
Location: newFp,
})
- console.log(chalk.yellow("[302]") + chalk.grey(` ${req.url} -> ${newFp}`))
+ console.log(chalk.yellow("[302]") + chalk.grey(` ${argv.baseDir}${req.url} -> ${newFp}`))
res.end()
}
@@ -484,15 +604,20 @@
return serve()
})
server.listen(argv.port)
- console.log(chalk.cyan(`Started a Quartz server listening at http://localhost:${argv.port}`))
+ const wss = new WebSocketServer({ port: 3001 })
+ wss.on("connection", (ws) => connections.push(ws))
+ console.log(
+ chalk.cyan(
+ `Started a Quartz server listening at http://localhost:${argv.port}${argv.baseDir}`,
+ ),
+ )
console.log("hint: exit with ctrl+c")
chokidar
.watch(["**/*.ts", "**/*.tsx", "**/*.scss", "package.json"], {
ignoreInitial: true,
})
.on("all", async () => {
- console.log(chalk.yellow("Detected a source code change, doing a hard rebuild..."))
- rebuild(clientRefresh)
+ build(clientRefresh)
})
} else {
await build(() => {})
--
Gitblit v1.10.0