From 4c9e8601504f76dcc3c273ea8ad1862df432b7b4 Mon Sep 17 00:00:00 2001
From: Andrew <80933354+ndrooo@users.noreply.github.com>
Date: Sat, 24 Aug 2024 20:33:30 +0000
Subject: [PATCH] a11y(darkmode): use a button for the theme toggle (#1335)
---
quartz/components/scripts/darkmode.inline.ts | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/quartz/components/scripts/darkmode.inline.ts b/quartz/components/scripts/darkmode.inline.ts
index 48e0aa1..038ae0f 100644
--- a/quartz/components/scripts/darkmode.inline.ts
+++ b/quartz/components/scripts/darkmode.inline.ts
@@ -11,7 +11,8 @@
document.addEventListener("nav", () => {
const switchTheme = (e: Event) => {
- const newTheme = (e.target as HTMLInputElement)?.checked ? "dark" : "light"
+ const newTheme =
+ document.documentElement.getAttribute("saved-theme") === "dark" ? "light" : "dark"
document.documentElement.setAttribute("saved-theme", newTheme)
localStorage.setItem("theme", newTheme)
emitThemeChangeEvent(newTheme)
@@ -21,17 +22,13 @@
const newTheme = e.matches ? "dark" : "light"
document.documentElement.setAttribute("saved-theme", newTheme)
localStorage.setItem("theme", newTheme)
- toggleSwitch.checked = e.matches
emitThemeChangeEvent(newTheme)
}
// Darkmode toggle
- const toggleSwitch = document.querySelector("#darkmode-toggle") as HTMLInputElement
- toggleSwitch.addEventListener("change", switchTheme)
- window.addCleanup(() => toggleSwitch.removeEventListener("change", switchTheme))
- if (currentTheme === "dark") {
- toggleSwitch.checked = true
- }
+ const themeButton = document.querySelector("#darkmode") as HTMLButtonElement
+ themeButton.addEventListener("click", switchTheme)
+ window.addCleanup(() => themeButton.removeEventListener("click", switchTheme))
// Listen for changes in prefers-color-scheme
const colorSchemeMediaQuery = window.matchMedia("(prefers-color-scheme: dark)")
--
Gitblit v1.10.0