From 2fdc8129b675d4e9090ba214a5a36646e630c817 Mon Sep 17 00:00:00 2001
From: Michael Thomason <mthomason@gmail.com>
Date: Sat, 01 Nov 2025 10:22:29 +0000
Subject: [PATCH] fix(components): prevent infinite recursion from circular transcludes (#2187)
---
quartz/components/scripts/darkmode.inline.ts | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/quartz/components/scripts/darkmode.inline.ts b/quartz/components/scripts/darkmode.inline.ts
index 48e0aa1..d8dfee9 100644
--- a/quartz/components/scripts/darkmode.inline.ts
+++ b/quartz/components/scripts/darkmode.inline.ts
@@ -10,8 +10,9 @@
}
document.addEventListener("nav", () => {
- const switchTheme = (e: Event) => {
- const newTheme = (e.target as HTMLInputElement)?.checked ? "dark" : "light"
+ const switchTheme = () => {
+ const newTheme =
+ document.documentElement.getAttribute("saved-theme") === "dark" ? "light" : "dark"
document.documentElement.setAttribute("saved-theme", newTheme)
localStorage.setItem("theme", newTheme)
emitThemeChangeEvent(newTheme)
@@ -21,16 +22,12 @@
const newTheme = e.matches ? "dark" : "light"
document.documentElement.setAttribute("saved-theme", newTheme)
localStorage.setItem("theme", newTheme)
- toggleSwitch.checked = e.matches
emitThemeChangeEvent(newTheme)
}
- // Darkmode toggle
- const toggleSwitch = document.querySelector("#darkmode-toggle") as HTMLInputElement
- toggleSwitch.addEventListener("change", switchTheme)
- window.addCleanup(() => toggleSwitch.removeEventListener("change", switchTheme))
- if (currentTheme === "dark") {
- toggleSwitch.checked = true
+ for (const darkmodeButton of document.getElementsByClassName("darkmode")) {
+ darkmodeButton.addEventListener("click", switchTheme)
+ window.addCleanup(() => darkmodeButton.removeEventListener("click", switchTheme))
}
// Listen for changes in prefers-color-scheme
--
Gitblit v1.10.0