From 2c8d0f8ab60cbf2e5e5338709e63267d466fb068 Mon Sep 17 00:00:00 2001
From: Jacky Zhao <j.zhao2k19@gmail.com>
Date: Mon, 22 Jan 2024 18:29:57 +0000
Subject: [PATCH] fix: more robust ofm comment handling
---
quartz/components/scripts/popover.inline.ts | 23 +++++------------------
1 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/quartz/components/scripts/popover.inline.ts b/quartz/components/scripts/popover.inline.ts
index 2bd21d1..4d51e2a 100644
--- a/quartz/components/scripts/popover.inline.ts
+++ b/quartz/components/scripts/popover.inline.ts
@@ -1,20 +1,5 @@
import { computePosition, flip, inline, shift } from "@floating-ui/dom"
-
-// from micromorph/src/utils.ts
-// https://github.com/natemoo-re/micromorph/blob/main/src/utils.ts#L5
-export function normalizeRelativeURLs(el: Element | Document, destination: string | URL) {
- const rebase = (el: Element, attr: string, newBase: string | URL) => {
- const rebased = new URL(el.getAttribute(attr)!, newBase)
- el.setAttribute(attr, rebased.pathname + rebased.hash)
- }
-
- el.querySelectorAll('[href^="./"], [href^="../"]').forEach((item) =>
- rebase(item, "href", destination),
- )
- el.querySelectorAll('[src^="./"], [src^="../"]').forEach((item) =>
- rebase(item, "src", destination),
- )
-}
+import { normalizeRelativeURLs } from "../../util/path"
const p = new DOMParser()
async function mouseEnterHandler(
@@ -22,6 +7,10 @@
{ clientX, clientY }: { clientX: number; clientY: number },
) {
const link = this
+ if (link.dataset.noPopover === "true") {
+ return
+ }
+
async function setPosition(popoverElement: HTMLElement) {
const { x, y } = await computePosition(link, popoverElement, {
middleware: [inline({ x: clientX, y: clientY }), shift(), flip()],
@@ -47,8 +36,6 @@
const hash = targetUrl.hash
targetUrl.hash = ""
targetUrl.search = ""
- // prevent hover of the same page
- if (thisUrl.toString() === targetUrl.toString()) return
const contents = await fetch(`${targetUrl}`)
.then((res) => res.text())
--
Gitblit v1.10.0