Sohum
2024-10-13 1dc208356abdcf8d3c0e826fd2184624298dd771
fix(cli): use shell on win32 for `update` (#1503) (#1504)

If there is no `npm.exe` on the system, but
instead an `npm.cmd`, then node won't find
the `npm` executable when calling `spawnSync`.

This occurs frequently when using node package
managers on Windows.

See the node documentation for `.bat` and `.cmd`
files here.

<https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows>.
1 files modified
20 ■■■■■ changed files
quartz/cli/handlers.js 20 ●●●●● patch | view | raw | blame | history
quartz/cli/handlers.js
@@ -457,7 +457,25 @@
  await popContentFolder(contentFolder)
  console.log("Ensuring dependencies are up to date")
  const res = spawnSync("npm", ["i"], { stdio: "inherit" })
  /*
  On Windows, if the command `npm` is really `npm.cmd', this call fails
  as it will be unable to find `npm`. This is often the case on systems
  where `npm` is installed via a package manager.
  This means `npx quartz update` will not actually update dependencies
  on Windows, without a manual `npm i` from the caller.
  However, by spawning a shell, we are able to call `npm.cmd`.
  See: https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows
  */
  const opts = { stdio: "inherit" }
  if (process.platform === "win32") {
    opts.shell = true
  }
  const res = spawnSync("npm", ["i"], opts)
  if (res.status === 0) {
    console.log(chalk.green("Done!"))
  } else {